Type def ColumnVec.

[alonh5]

This change is 

[alonh5]

Current dependencies on/for this PR:

• Create ColumnDomainsVisitor. #376
• Create MaskEvaluator. #375
• Move max_constraint_log_degree_bound to AirExt trait. #373
• Move CP evaluation to AirExt trait. #372
• Type def ColumnVec. #371 👈
• max_constraint_log_degree_bound in Air trait. #370
• Create FibonnaciAir. #369
• Contain queries in FRI. #355
• Get opening positions from FRI. #354
• Get degree bounds from component. #351
• dev

This stack of pull requests is managed by Graphite.

[ohad-starkware]

Reviewed 5 of 6 files at r1, all commit messages.
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @spapinistarkware)

---

src/core/mod.rs line 15 at r1 (raw file):

pub mod utils;

pub type ColumnVec<T> = Vec<Vec<T>>;

Looks good, but here's a problem that I've encountered dealing with these type_defs:
you never want to clone them, so if they're not pre-aggregated, you get &[&[F]] types,
idk if that's bad code on my part, but maybe you should consider covering these cases:
e.g.

}

Code snippet:

pub fn foo(arr: &ColumnVec<M31>){}

pub fn bar(){
let arr = vec![[M31::from_u32_unchecked(1); 10]; 10];

foo(&arr); <--- won't compile

[ohad-starkware]

Reviewed 1 of 6 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

The base branch was changed.

[ohad-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)