-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move entire baxterlgv7 #2622
Merged
Merged
Move entire baxterlgv7 #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pazeshun
force-pushed
the
move-whole-baxterlgv7
branch
from
January 17, 2018 03:21
6b78a48
to
7b93999
Compare
I'll separate directory to distinguish configs for baxterlgv7 from configs for baxter in jsk_arc2017_baxter |
pazeshun
force-pushed
the
move-whole-baxterlgv7
branch
from
January 18, 2018 09:42
ee2efec
to
a5eef1c
Compare
Tested with both current baxter and baxterlgv7 |
pazeshun
force-pushed
the
move-whole-baxterlgv7
branch
from
January 19, 2018 02:44
522b16f
to
a4fb07c
Compare
Tested with real robots again |
@knorth55 Can you review this again? |
knorth55
approved these changes
Jan 22, 2018
Please merge this |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds what I hadn't finished in #2616
baxterlgv7.launch
having the same role asbaxter.launch
Video
https://drive.google.com/open?id=17pm61w8mhTPbMPij-iadqmwhHluaxyAt
(Please download to see clearly)
I confirmed real robot also moved correctly when I took video