Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make struct mutable and other improvements #7

Merged
merged 11 commits into from
Aug 30, 2024
Merged

Make struct mutable and other improvements #7

merged 11 commits into from
Aug 30, 2024

Conversation

stecrotti
Copy link
Owner

@stecrotti stecrotti commented Aug 29, 2024

Changes:

  • Struct is now mutable. Shouldn't be a big peformance issue since typical use does not involve creating many instances in performance-sensitive parts of the code
  • Added recompute_partials!(x::UniformIsing) to update the pre-computed quantities stored in the struct after a change in the parameters (J,h,beta)
  • Some house-keeping, re-organized files, replaced imports with usings as per the guidelines
  • Add a benchmark
  • Add some tests

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 99.31507% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.51%. Comparing base (ffcb95d) to head (5c5b856).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/uniform_ising.jl 99.26% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main       #7       +/-   ##
===========================================
+ Coverage   84.94%   99.51%   +14.56%     
===========================================
  Files           2        3        +1     
  Lines         186      205       +19     
===========================================
+ Hits          158      204       +46     
+ Misses         28        1       -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stecrotti stecrotti merged commit 255526e into main Aug 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant