Update to embedded-hal v1.0.0-alpha.1 #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxekman
commented
Apr 28, 2020
| @@ -105,7 +107,7 @@ impl Timer<SYST> { | |||
| { | |||
| syst.set_clock_source(SystClkSource::Core); | |||
| let mut timer = Timer { tim: syst, clocks }; | |||
| timer.start(timeout); | |||
| let _ = timer.try_start(timeout); | |||
There was a problem hiding this comment.
Not sure about this way to handle the unused Result, suggestions?
5 tasks
maxekman
force-pushed
the
update-to-try-functions
branch
3 times, most recently
from
e31ef63
to
f94d109
Compare
maxekman
commented
Apr 30, 2020
maxekman
changed the title
|
You may update to version embedded-hal's |
|
Thanks @luojia65, I’ll do that. |
|
Linking to rust-embedded/embedded-hal#177 |
maxekman
force-pushed
the
update-to-try-functions
branch
from
f94d109
to
dd14acc
Compare
maxekman
changed the title
maxekman
force-pushed
the
update-to-try-functions
branch
from
dd14acc
to
a1316e8
Compare
|
I'll close this as it's not updated according to the guidelines for how to support 0.2.x and 1.0.0-alpha: https://github.com/rust-embedded/embedded-hal#adding-support-for-an-embedded-hal--alpha-version-in-a-hal-implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to have the crate updated to use the new embedded-hal traits for the development of the I2S proposal (rust-embedded/embedded-hal#204).
I'm new to the Rust and Rust embedded eco systems and not familiar with how the updates are usually done to all the HAL crates under stm32-rs, but I'll be glad to provide this if helpful. I'll leave it open for comments and further work until embedded-hal has released its next version (1.0?).