fix: icons on index page #2381
Merged
fix: icons on index page #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subhod-i
approved these changes
Oct 9, 2023
|
Deployed to fix-icons-on-index-page.wallet.z52da5wt.xyz, artifacts |
peronczyk
requested changes
Oct 10, 2023
| @@ -34,6 +34,7 @@ export default defineComponent({ | |||
|
|
|||
| .platform-icon { | |||
| height: 44px; | |||
| width: 40px; | |||
There was a problem hiding this comment.
The issue is not caused by wrong sizing but with the fact that the element is affect by flex shrinking. I suggest to replace the change with flex-shrink: 0.
There was a problem hiding this comment.
Without width: 40px; it still doesn't look exactly like product
martinkaintas
force-pushed
the
fix/icons-on-index-page
branch
from
d1b913b to
02fb45e
Compare
martinkaintas
force-pushed
the
fix/icons-on-index-page
branch
from
02fb45e to
48f0001
Compare
peronczyk
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.