Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: icons on index page #2381

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix: icons on index page #2381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/popup/components/PlatformIcon.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,12 @@ export default defineComponent({

.platform-icon {
height: 44px;
width: 40px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is not caused by wrong sizing but with the fact that the element is affect by flex shrinking. I suggest to replace the change with flex-shrink: 0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without width: 40px; it still doesn't look exactly like product

padding: 2px 0;

.platform-icon-image {
height: 40px;
width: 40px;
height: 100%;
margin: 0 auto;
transition: all 0.15s ease-in-out;

&.grey {
Expand Down
Loading