Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wallet manager package #12

Merged
merged 52 commits into from
Nov 29, 2023
Merged

feat: wallet manager package #12

merged 52 commits into from
Nov 29, 2023

Conversation

wainola
Copy link
Contributor

@wainola wainola commented Sep 15, 2023

Description

Related Issue Or Context

Closes: #5

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in sygma-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@wainola
Copy link
Contributor Author

wainola commented Sep 15, 2023 •
edited
Loading

note that based for this branch is the pipelines one

@wainola wainola requested a review from FSM1 September 28, 2023 13:38
@wainola wainola marked this pull request as ready for review October 2, 2023 12:35
FSM1
FSM1 reviewed Nov 3, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
FSM1
FSM1 previously approved these changes Nov 7, 2023
View reviewed changes
@wainola wainola requested review from sztok7 and FSM1 November 7, 2023 21:39
FSM1
FSM1 previously approved these changes Nov 22, 2023
View reviewed changes
@wainola wainola requested a review from FSM1 November 23, 2023 03:36
FSM1
FSM1 previously approved these changes Nov 23, 2023
View reviewed changes
sztok7
sztok7 requested changes Nov 28, 2023
View reviewed changes
.yarn/releases/yarn-3.6.3.cjs Outdated Show resolved Hide resolved
packages/wallet-manager/src/WalletManagerContext.ts Outdated Show resolved Hide resolved
packages/wallet-manager/src/interfaces/index.ts Outdated Show resolved Hide resolved
@wainola wainola requested review from sztok7 and FSM1 November 29, 2023 11:35
sztok7
sztok7 previously approved these changes Nov 29, 2023
View reviewed changes
packages/wallet-manager/src/WalletManagerContext.ts Outdated Show resolved Hide resolved
@wainola wainola merged commit fe5a788 into main Nov 29, 2023
2 checks passed
@FSM1 FSM1 deleted the feat/wallet-manager-package branch November 29, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sztok7 sztok7 sztok7 approved these changes

@FSM1 FSM1 FSM1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Wallet Manager Package
3 participants
@wainola @FSM1 @sztok7