Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wallet manager package #12
feat: wallet manager package #12
Changes from 20 commits
2eac503
c41a2bc
3ffdae4
4fa5870
0788c62
c60f73e
428f718
fe0dc5d
74c9649
a8861d0
94fd2b0
e6caa8d
43666c3
08e7d70
5149995
8697e81
8c9b14b
e41ebd4
1c3cd31
c3e76e3
fa18c10
c90ab38
ad4b54a
e6c6c0e
d295070
1386eb8
b099ce9
556c825
797c073
95b496d
a4cfef5
98d0120
2c5ad0a
6319a44
3f74c0c
2a80e1e
eb39261
94d5694
2684963
40592ce
fba19a5
f04f2b0
909bace
d002ac2
244bc78
68ba84d
ab3e13f
c3ab7da
47302b8
7b90cae
3fdf418
9405bd5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as for the EVM wallet init
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem here is that intantiation passing the
wssProvider
requires awaiting the result ofApiPromise.create
, in contrast to the evm side, where either you pass the provider or notThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it matter?