Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue https://github.com/tensorflow/tensorflow/issues/75196 #2324

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

sanskarmodi8
Copy link
Contributor

fixed several issues in save_and_load.ipynb notebook in keras tutorials as mentioned in Tensorflow issue #75196

@sanskarmodi8 sanskarmodi8 requested a review from a team as a code owner September 8, 2024 11:54
Copy link

github-actions bot commented Sep 8, 2024

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin issue#75196-fix

@sanskarmodi8
Copy link
Contributor Author

Are there any updates on this?

Copy link
Member

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the update. This mostly looks good,

The one issue is that the checkpoint directories aren't being automatically created.

Be sure to run an end-to-end test in colab:

https://colab.sandbox.google.com/github/sanskarmodi8/tf-docs/blob/issue%2375196-fix/site/en/tutorials/keras/save_and_load.ipynb

MarkDaoust
MarkDaoust previously approved these changes Sep 10, 2024
Copy link
Member

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MarkDaoust MarkDaoust added the ready to pull Start merge process label Sep 10, 2024
@MarkDaoust
Copy link
Member

Fixed. Thanks!

@sanskarmodi8
Copy link
Contributor Author

sanskarmodi8 commented Sep 11, 2024

Fixed. Thanks!

Thanks for pointing it out and pushing changes. I will format the notebook and push it soon enough so that the lint check passes.

@sanskarmodi8
Copy link
Contributor Author

sanskarmodi8 commented Sep 11, 2024

Hey @MarkDaoust ,
I have formatted the notebook using nbfmt after considering your mkdir change so that it pass the lint check it was failing earlier

@MarkDaoust
Copy link
Member

LGTM. Thanks, this is being merged. It will complete soon.

@sanskarmodi8
Copy link
Contributor Author

LGTM. Thanks, this is being merged. It will complete soon.

Thank you. Actually, it was failing a linting test as I didn't used proper linting so I applied proper linting and then pushed the commit

copybara-service bot pushed a commit that referenced this pull request Sep 12, 2024
@sanskarmodi8
Copy link
Contributor Author

sanskarmodi8 commented Sep 13, 2024

Hey @MarkDaoust ,
Any updates on this??

@copybara-service copybara-service bot merged commit 98fa059 into tensorflow:master Sep 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to pull Start merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants