-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed issue https://github.com/tensorflow/tensorflow/issues/75196 #2324
fixed issue https://github.com/tensorflow/tensorflow/issues/75196 #2324
Conversation
…ls as mentioned in issue #75196
PreviewPreview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.Format and styleUse the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:$ python3 -m pip install -U --user git+https://github.com/tensorflow/docsIf commits are added to the pull request, synchronize your local branch: git pull origin issue#75196-fix
|
Are there any updates on this? |
f545638
to
a2a302e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the update. This mostly looks good,
The one issue is that the checkpoint directories aren't being automatically created.
Be sure to run an end-to-end test in colab:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Fixed. Thanks! |
Thanks for pointing it out and pushing changes. I will format the notebook and push it soon enough so that the lint check passes. |
Hey @MarkDaoust , |
LGTM. Thanks, this is being merged. It will complete soon. |
Thank you. Actually, it was failing a linting test as I didn't used proper linting so I applied proper linting and then pushed the commit |
PiperOrigin-RevId: 673591318
Hey @MarkDaoust , |
fixed several issues in save_and_load.ipynb notebook in keras tutorials as mentioned in Tensorflow issue #75196