Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract directly from text #150

Open
tgockel opened this issue Mar 3, 2020 · 0 comments
Open

Extract directly from text #150

tgockel opened this issue Mar 3, 2020 · 0 comments
Assignees
@tgockel
Milestone
Version 2.0.0

Comments

@tgockel
Copy link
Owner

tgockel commented Mar 3, 2020

Instead of only parsing into a jsonv::value, there should be a extractor which works directly on an AST index. This will allow extraction without the jsonv::value middleman.
@tgockel tgockel self-assigned this Mar 3, 2020
@tgockel tgockel added this to the Version 2.0.0 milestone Mar 3, 2020
tgockel added a commit that referenced this issue Mar 3, 2020
@tgockel
Dedicated parsing into an AST index.
48ebecd 
Creating an AST is significantly faster than the equivalent
`jsonv::parse` call (approximately 10x speedup). This completely removes
the older `tokenizer` structure and replaces it was a flat `ast_index`
structure.

This commit introduces #145, which calls to revisit `parse_options` and
the associated `parse_error`. Now that the parse phase and extraction to
a JSON `value` are separate, the old configuration options make less
sense. This also enables work on #150, which calls to extract directly
from source text.

- Fixes #147
- Fixes #96 through `ast_node::integer` and `ast_node::decimal`
- Closes #97 by removal of `tokenizer`
tgockel added a commit that referenced this issue Mar 3, 2020
@tgockel
Dedicated parsing into an AST index.
6e1fcb7 
Creating an AST is significantly faster than the equivalent
`jsonv::parse` call (approximately 10x speedup). This completely removes
the older `tokenizer` structure and replaces it was a flat `ast_index`
structure.

This commit introduces #145, which calls to revisit `parse_options` and
the associated `parse_error`. Now that the parse phase and extraction to
a JSON `value` are separate, the old configuration options make less
sense. This also enables work on #150, which calls to extract directly
from source text.

- Fixes #147
- Fixes #96 through `ast_node::integer` and `ast_node::decimal`
- Closes #97 by removal of `tokenizer`
tgockel added a commit that referenced this issue Mar 4, 2020
@tgockel
Dedicated parsing into an AST index.
efc80dc 
Creating an AST is significantly faster than the equivalent
`jsonv::parse` call (approximately 10x speedup). This completely removes
the older `tokenizer` structure and replaces it was a flat `parse_index`
structure.

This commit introduces #145, which calls to revisit `parse_options` and
the associated `parse_error`. Now that the parse phase and extraction to
a JSON `value` are separate, the old configuration options make less
sense. This also enables work on #150, which calls to extract directly
from source text.

- Fixes #147
- Fixes #96 through `ast_node::integer` and `ast_node::decimal`
- Closes #97 by removal of `tokenizer`
@tgockel tgockel mentioned this issue Apr 23, 2022
Closed
tgockel added a commit that referenced this issue Apr 23, 2022
@tgockel
Creates reader type for converting from JSON source to AST node seq…
7567f7a 
…uence

A `jsonv::reader` instance reads from some form of JSON source (probably
a string, but the `jsonv::ast_index` type can theoretically read from
anything JSON-like) and converts it into `jsonv::ast_node`s. These
abstract reading from JSON source to normalize `extract` implementations,
which is needed for #150.

- Resolves #171
@tgockel tgockel mentioned this issue Apr 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgockel tgockel

Labels
None yet
Projects
None yet
Milestone
Version 2.0.0
Development

No branches or pull requests
1 participant
@tgockel