-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new profiles to hadge #24
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@Zethson ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really really awesome. What happens now if I specify Docker or Conda and attempt to run Souporcell? We're not gracefully handling the issue, are we?
Now we should be able to bring it all together:
Please add a Github Actions workflow that runs the test profile using https://github.com/marketplace/actions/setup-nextflow
If everything is well designed and works with Conda/Docker (except for souporcell) this should hopefully be a piece of cake.
This will be a nice major milestone.
Thank you very much!
params { | ||
outdir = "result_test" | ||
// input for hashing-based deconvolution | ||
hto_matrix_raw = "$projectDir/test_data/hto" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally all of these should eventually be fetched directly from the cloud but let's not bother with that for now. Downloading them with the script is OK.
Is it possible to upload the test data to cloud which can be used by github workflow action directly? Reference genome is tooooo large... |
Ohhh I see. nf-core has small test reference genomes. See: https://github.com/nf-core/rnaseq/blob/master/conf/test.config#L27 |
conda
,docker
,arm
,test
, like in nf-coreFALSE
toFalse
, reduce mixed-case problem