Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new profiles to hadge #24

Merged
merged 32 commits into from
Nov 17, 2023
Merged

Add new profiles to hadge #24

merged 32 commits into from
Nov 17, 2023

Conversation

wxicu
Copy link
Collaborator

@wxicu wxicu commented Nov 4, 2023

  1. add profiles conda, docker, arm, test, like in nf-core
  2. Change some values of parameter from FALSE to False, reduce mixed-case problem
  3. Specify conda configuration in conda directive. Customized conda configuration is recommended to specify in a new profile now
  4. docs is adapted

@wxicu wxicu requested a review from Zethson November 4, 2023 21:06
@wxicu wxicu marked this pull request as draft November 4, 2023 22:45
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wxicu wxicu marked this pull request as ready for review November 6, 2023 13:53
@wxicu
Copy link
Collaborator Author

wxicu commented Nov 6, 2023

@Zethson ready for review

Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really really awesome. What happens now if I specify Docker or Conda and attempt to run Souporcell? We're not gracefully handling the issue, are we?

Now we should be able to bring it all together:

Please add a Github Actions workflow that runs the test profile using https://github.com/marketplace/actions/setup-nextflow
If everything is well designed and works with Conda/Docker (except for souporcell) this should hopefully be a piece of cake.

This will be a nice major milestone.

Thank you very much!

test.config Outdated Show resolved Hide resolved
params {
outdir = "result_test"
// input for hashing-based deconvolution
hto_matrix_raw = "$projectDir/test_data/hto"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally all of these should eventually be fetched directly from the cloud but let's not bother with that for now. Downloading them with the script is OK.

modules/single/hash_demultiplexing.nf Outdated Show resolved Hide resolved
modules/single/hash_demulti/demuxem.nf Outdated Show resolved Hide resolved
@wxicu
Copy link
Collaborator Author

wxicu commented Nov 7, 2023

This is really really awesome. What happens now if I specify Docker or Conda and attempt to run Souporcell? We're not gracefully handling the issue, are we?

Now we should be able to bring it all together:

Please add a Github Actions workflow that runs the test profile using https://github.com/marketplace/actions/setup-nextflow If everything is well designed and works with Conda/Docker (except for souporcell) this should hopefully be a piece of cake.

This will be a nice major milestone.

Thank you very much!

Is it possible to upload the test data to cloud which can be used by github workflow action directly? Reference genome is tooooo large...

@Zethson
Copy link
Member

Zethson commented Nov 7, 2023

Ohhh I see. nf-core has small test reference genomes. See: https://github.com/nf-core/rnaseq/blob/master/conf/test.config#L27

@Zethson Zethson merged commit ebaee50 into main Nov 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants