Add safe navigation for user_interaction_count (#226)

* Add safe navigation for user_interaction_count * Add new VCR cassettes * Update VCR cassettes * Remove unwanted cassettes * Fix API cassette * Fix tests
thibaudgg · Oct 27, 2023 · 52ac0a7 · 52ac0a7
1 parent 2a94d69
commit 52ac0a7
Show file tree

Hide file tree

Showing 4 changed files with 352 additions and 2 deletions.
diff --git a/lib/video_info/providers/vimeo_scraper.rb b/lib/video_info/providers/vimeo_scraper.rb
@@ -131,9 +131,9 @@ def stats
       private
 
       def user_interaction_count(interaction_type:)
-        interaction_statistic.find do |stat|
+        interaction_statistic&.find do |stat|
           stat["interactionType"] == "http://schema.org/#{interaction_type}"
-        end["userInteractionCount"]
+        end&.public_send(:[], "userInteractionCount")
       end
 
       def interaction_statistic

diff --git a/spec/fixtures/vcr_cassettes/VideoInfo_Providers_Vimeo/with_video_7848846/stats/1_14_1_1.yml b/spec/fixtures/vcr_cassettes/VideoInfo_Providers_Vimeo/with_video_7848846/stats/1_14_1_1.yml
diff --git a/spec/fixtures/vcr_cassettes/VideoInfo_Providers_Vimeo/with_video_7848846/stats/2_14_1_1.yml b/spec/fixtures/vcr_cassettes/VideoInfo_Providers_Vimeo/with_video_7848846/stats/2_14_1_1.yml
diff --git a/spec/lib/video_info/providers/vimeo_spec.rb b/spec/lib/video_info/providers/vimeo_spec.rb
@@ -336,5 +336,23 @@
         its(:view_count) { should be nil }
       end
     end
+
+    context "with video 7848846" do
+      subject { VideoInfo.new("https://vimeo.com/7848846") }
+
+      its(:stats) {
+        if api_key
+          should eq({
+            "plays" => nil,
+          })
+        else
+          should eq({
+            "plays" => nil,
+            "likes" => nil,
+            "comments" => nil
+          })
+        end
+      }
+    end
   end
 end