Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-Platform SigMint Improvements + Pk Override Fixes, PlayMode Tests, Better Return Types, Storage Fix #161

Merged
merged 61 commits into from
Mar 22, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Mar 21, 2024

PR-Codex overview

The focus of this PR is to update data types to BigInteger for better precision and handle WebGL build limitations.

Detailed summary

  • Updated data types to BigInteger for better precision
  • Handled WebGL build limitations for file writing
  • Improved error handling for data parsing
  • Refactored SDK initialization for consistency

The following files were skipped due to too many changes: Assets/Tests/TransactionReadTests.cs, Assets/Thirdweb/Core/Scripts/Utils.cs, Assets/Thirdweb/Core/Scripts/ThirdwebManager.cs, Assets/Tests/EventsTests.cs, Assets/Thirdweb/Core/Scripts/ERC20.cs, Assets/Tests/PackReadTests.cs, Assets/Thirdweb/Core/Scripts/Pack.cs, Assets/Tests/ERC20ReadTests.cs, Assets/Tests/ERC20WriteTests.cs, Assets/Tests/ERC1155WriteTests.cs, Assets/Tests/SmartWalletTests.cs, Assets/Tests/ERC721ReadTests.cs, Assets/Tests/ERC721WriteTests.cs, Assets/Tests/ERC1155ReadTests.cs, .github/workflows/main.yml, Assets/Thirdweb/Core/Scripts/ERC721.cs, Assets/Tests/StorageTests.cs, Assets/Tests/ThirdwebManagerTests.cs, Assets/Tests/WalletTests.cs, Assets/Tests/MarketplaceReadTests.cs, Assets/Thirdweb/Core/Scripts/ERC1155.cs, Assets/Tests/CustomReadTests.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0xFirekeeper 0xFirekeeper marked this pull request as ready for review March 21, 2024 03:44
Copy link

github-actions bot commented Mar 21, 2024

Test Results

  1 files   12 suites   5m 44s ⏱️
 96 tests  96 ✅ 0 💤 0 ❌
100 runs  100 ✅ 0 💤 0 ❌

Results for commit 4efdc85.

♻️ This comment has been updated with latest results.

@0xFirekeeper 0xFirekeeper merged commit 2aa7906 into main Mar 22, 2024
6 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/tests branch March 22, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant