Add access to the scales at draw time using a new layer_params object
#3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s an arg, move layer_params to get assigned in setup_layer().
|
@hadley Could you take a look at the way this PR uses ggproto to generate a |
|
This is temporarily on hold pending further discussion on issue #3175. |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR addressing #3116, and allows access to the trained scales at draw time through a new
layer_paramsargument toGeom$draw_layer(). This enables geometries that may require extensive loading of data to be drawn lazily (among other things). The overall structure of using a new argument toGeom$draw_layer()was discussed at length in the issue, but the details of the implementation and testing could definitely use the keen eye of those more familiar with the ggplot2 internals. Cheers!