Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add access to the scales at draw time using a new layer_params object #3170

Closed
wants to merge 4 commits into from
Closed

Add access to the scales at draw time using a new layer_params object #3170

wants to merge 4 commits into from

Commits on Feb 19, 2019

  1. implement layer params that live in the layer

    @paleolimbot
    paleolimbot committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    696e7dd View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2019

  1. make layer_params a ggproto object, modify get_scale to take layout a… 

    …s an arg, move layer_params to get assigned in setup_layer().
    @paleolimbot
    paleolimbot committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    be19517 View commit details
    Browse the repository at this point in the history

  2. remove ref to scales list, fix layout scale getting

    @paleolimbot
    paleolimbot committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    295eee2 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2019

  1. add test and news item in prep for PR

    @paleolimbot
    paleolimbot committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    037b9e4 View commit details
    Browse the repository at this point in the history