fix(velodyne_decoder): vlp16 and vlp32 overflow handling

[bgilby59]

PR Type

• Bug Fix

Related Links

#111

Description

This PR extends the changes in #111. See Nebula-only problem in that PR description for a detailed overview of the problem.

Review Procedure

Code review (currently do not have rosbags that can reproduce this issue).

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• (Optional) Unit tests have been written for new behavior
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR: Required to pass before the merge.

[codecov-commenter]

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (04d8d38) 6.47% compared to head (12077a8) 11.48%.

Files	Patch %	Lines
...ebula_decoders_velodyne/decoders/vlp32_decoder.cpp	0.00%	21 Missing ⚠️
...ebula_decoders_velodyne/decoders/vlp16_decoder.cpp	71.42%	4 Missing and 2 partials ⚠️
...bula_decoders_velodyne/decoders/vls128_decoder.cpp	0.00%	3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff            @@
##            main     #113      +/-   ##
=========================================
+ Coverage   6.47%   11.48%   +5.00%     
=========================================
  Files        136       60      -76     
  Lines      10927     5592    -5335     
  Branches     857      804      -53     
=========================================
- Hits         708      642      -66     
+ Misses      9643     4396    -5247     
+ Partials     576      554      -22     

Flag	Coverage Δ
differential	11.48% <33.33%> (?)
total	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[knzo25]

Left some comments 🙏

[knzo25]

@bgilby59
Please remember to "resolve" the review comments and ask for a review again when you finish

[bgilby59]

@knzo25 Thank you for your review. I have addressed your comments. Please review the changes I made when you have time.

[knzo25]

LGTM !