Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(robosense): include DIFOP packets in record/replay functionality #213

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Oct 30, 2024

PR Type

  • Bug Fix

Related Links

Description

Since Nebula v0.2.0, or more specifically, since PR #147, DIFOP ("info") packets are not recorded/replayed anymore by Nebula.
This made diagnosing https://github.com/orgs/autowarefoundation/discussions/5378 impossible since the sensor configuration was not recorded.

Review Procedure

Remarks

Tested with the Helios PCAP from here.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex self-assigned this Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 26.07%. Comparing base (214373a) to head (b1d7a7c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
nebula_ros/src/robosense/robosense_ros_wrapper.cpp 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   25.88%   26.07%   +0.18%     
==========================================
  Files          99       99              
  Lines        9190     9113      -77     
  Branches     2211     2187      -24     
==========================================
- Hits         2379     2376       -3     
+ Misses       6426     6353      -73     
+ Partials      385      384       -1     
Flag Coverage Δ
differential 26.07% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mojomex mojomex merged commit a908f61 into tier4:main Nov 1, 2024
11 of 12 checks passed
@mojomex mojomex deleted the fix/robosense-packet-replay branch November 1, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants