Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hesai): add decoder unit tests for OT128, QT128 #214

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Oct 30, 2024

PR Type

  • Improvement

Description

There were no unit tests for pointcloud output for QT128 and OT128. I had the opportunity to record some data today and made unit tests. Here's the reference pointclouds:

QT128 OT128
Screenshot from 2024-10-30 22-06-50 Screenshot from 2024-10-30 22-07-35

The OT128 was on its head and in a confined space and thus the pointcloud looks a little weird. The output is correct though.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • [z] Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex requested a review from drwnz October 30, 2024 13:09
@mojomex mojomex self-assigned this Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.54%. Comparing base (214373a) to head (88d2ced).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #214       +/-   ##
===========================================
+ Coverage   25.88%   55.54%   +29.65%     
===========================================
  Files          99       65       -34     
  Lines        9190     4274     -4916     
  Branches     2211     1141     -1070     
===========================================
- Hits         2379     2374        -5     
+ Misses       6426     1538     -4888     
+ Partials      385      362       -23     
Flag Coverage Δ
differential 55.54% <ø> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mojomex mojomex enabled auto-merge (squash) November 1, 2024 09:22
@mojomex mojomex disabled auto-merge November 1, 2024 09:22
@mojomex mojomex merged commit 3fceb3d into tier4:main Nov 1, 2024
12 checks passed
@mojomex mojomex deleted the chore/decoder-tests-for-ot128-qt128 branch November 1, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant