Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hesai_hw_interface): use dependency-injected logger, get rid of RCLCPP dependency #232

Merged
merged 4 commits into from
Nov 26, 2024
Merged

feat(hesai_hw_interface): use dependency-injected logger, get rid of RCLCPP dependency #232

merged 4 commits into from
Nov 26, 2024
+84 −129

Commits on Nov 25, 2024

  1. chore(hesai_hw_interfaces): switch to the new loggers::Logger class, … 

    …remove rclcpp dependency 🎉

Signed-off-by: Max SCHMELLER <[email protected]>
    @mojomex
    mojomex committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    d366989 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. chore(hesai): use angle brackets for out-of-package import 

    Signed-off-by: Max SCHMELLER <[email protected]>
    @mojomex
    mojomex committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    e37efce View commit details
    Browse the repository at this point in the history

  2. ci(pre-commit): autofix

    @pre-commit-ci
    pre-commit-ci[bot] committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    f577b1e View commit details
    Browse the repository at this point in the history

  3. chore(hesai_hw_interface): pass logger shared_ptr by constref 

    Signed-off-by: Max SCHMELLER <[email protected]>
    @mojomex
    mojomex committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    755d722 View commit details
    Browse the repository at this point in the history