Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(velodyne_ros_wrapper): add profiling log to velodyne #51

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

mebasoglu
Copy link
Collaborator

PR Type

  • Improvement

Related Links

@mojomex created profiling scripts in this PR: #37

Description

Thanks to @mojomex, it is easy to measure performance of the driver. However the necessary logging code wasn't added for Velodyne. I added the logging to velodyne_decoder_ros_wrapper.cpp so that it is possible to use existing scripts to mesure process time for also Velodyne lidars.

Review Procedure

The only modification is on velodyne_decoder_ros_wrapper.cpp. I added logging code according to hesai_decoder_ros_wrapper.cpp.

After building the package, go to the scripts directory and run:

./profiling_runner.bash vlp16 -m VLP16 -b <your_bag_file_which_includes_/velodyne_packets>
./profiling_runner.bash vls128 -m VLS128 -b <your_bag_file_which_includes_/velodyne_packets>

python3 plot_times.py vlp16

Here is the result I got for VLP16 and VLS128:

vlp16 vls128
d_total AVG 6.90601 30.3898
n_out AVG 15358.4 198887
d_total STD 2.60609 9.6811
n_out STD 103.414 87.4213
d_total AVG % rel to vlp16 100 440.048
n_out AVG % rel to vlp16 100 1294.97
d_total STD % rel to vlp16 100 371.479
n_out STD % rel to vlp16 100 84.5355

Timing_comparison

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@drwnz drwnz requested review from amc-nu and drwnz August 10, 2023 00:49
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.12% ⚠️

Comparison is base (8f33f79) 13.36% compared to head (ce320bd) 11.24%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   13.36%   11.24%   -2.12%     
==========================================
  Files         111       33      -78     
  Lines       10986     4623    -6363     
  Branches     1725     1145     -580     
==========================================
- Hits         1468      520     -948     
+ Misses       8342     3160    -5182     
+ Partials     1176      943     -233     
Flag Coverage Δ
differential 11.24% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
..._ros/src/velodyne/velodyne_decoder_ros_wrapper.cpp 0.00% <0.00%> (ø)

... and 78 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amc-nu amc-nu merged commit 5d4b39a into tier4:main Aug 21, 2023
6 of 7 checks passed
@mebasoglu mebasoglu deleted the add-profiling-log-velodyne branch August 23, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants