Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Ronbosense lidar #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FelixHuang18
Copy link

PR Type

  • New Feature

Description

This change proposes Robosense Helios 16 、Helios32 、Bpearl 、Ruby Plus 、M1 Plus and E1 support for nebula.

Review Procedure

Remarks

We have tested these newly added codes using the corresponding Robosense Lidar and all tests have passed.
To meet our needs, we have added a function in the TcpDriver class (i.e. bool asyncSendReceive (std:: vector&buff, Functor func). By the way, the code we have added contains abbreviations for some proprietary terms, such as (MSOP: Main data Stream Output Protocol), which cannot pass spell checking. Can you solve this problem?

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@FelixHuang18 FelixHuang18 changed the title support Ronbosense Helios32/Helios16/Bpearl/RubyPlus/M1Plus/E1 feat:support Ronbosense Helios32/Helios16/Bpearl/RubyPlus/M1Plus/E1 Sep 27, 2023
@FelixHuang18 FelixHuang18 changed the title feat:support Ronbosense Helios32/Helios16/Bpearl/RubyPlus/M1Plus/E1 feat: support Ronbosense lidar Sep 27, 2023
@FelixHuang18
Copy link
Author

Hello, I am from Robosense. This change proposes Robosense Helios 16, Helios32, Bpearl, Ruby Plus, M1 Plus and E1 support for nebula. Please review this change. If you have any questions, please feel free to contact [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant