Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix sync isolation level to default placement rule #7122

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Sep 20, 2023

What problem does this PR solve?

Issue Number: Close #7121.

What is changed and how does it work?

This PR will sync the isolation level to the default rule when setting config with HTTP API or pd-ctl.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 20, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 20, 2023
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and nolouch September 20, 2023 10:50
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 20, 2023
@rleungx rleungx force-pushed the fix-isolation-level branch from c2d8b9e to 2bf92ca Compare September 20, 2023 10:51
@rleungx rleungx requested review from JmPotato and removed request for lhy1024 September 20, 2023 10:52
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #7122 (2bf92ca) into master (a997316) will increase coverage by 0.05%.
Report is 1 commits behind head on master.
The diff coverage is 78.57%.

❗ Current head 2bf92ca differs from pull request most recent head 5e123e2. Consider uploading reports for the commit 5e123e2 to get more accurate results

@@            Coverage Diff             @@
##           master    #7122      +/-   ##
==========================================
+ Coverage   74.32%   74.37%   +0.05%     
==========================================
  Files         440      440              
  Lines       47195    47157      -38     
==========================================
- Hits        35076    35073       -3     
+ Misses       9024     8997      -27     
+ Partials     3095     3087       -8     
Flag Coverage Δ
unittests 74.37% <78.57%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 21, 2023
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we update the isolation-level? Will it be set to the rule also?

@rleungx
Copy link
Member Author

rleungx commented Sep 21, 2023

What if we update the isolation-level? Will it be set to the rule also?

Do you mean TestUpdateDefaultReplicaConfig?

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 21, 2023
@JmPotato
Copy link
Member

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 2bf92ca

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #7123.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 21, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #7124.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 21, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #7125.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 21, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #7126.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 21, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #7127.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 21, 2023
@rleungx rleungx deleted the fix-isolation-level branch September 21, 2023 06:30
ti-chi-bot bot added a commit that referenced this pull request Sep 28, 2023
close #7121

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ryan Leung <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this pull request Nov 22, 2023
close #7121

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ryan Leung <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
rleungx added a commit to ti-chi-bot/pd that referenced this pull request May 11, 2024
ti-chi-bot bot added a commit that referenced this pull request Sep 10, 2024
close #7121

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ryan Leung <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isolation level is not synchronize to default rule when setting with pd-ctl
4 participants