Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix sync isolation level to default placement rule (#7122) #7125

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7122

What problem does this PR solve?

Issue Number: Close #7121.

What is changed and how does it work?

This PR will sync the isolation level to the default rule when setting config with HTTP API or pd-ctl.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Sep 21, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from nolouch and rleungx September 21, 2023 06:26
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 21, 2023
@rleungx rleungx force-pushed the cherry-pick-7122-to-release-6.1 branch from 444a4db to d3d3bc7 Compare September 22, 2023 09:35
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 22, 2023
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx force-pushed the cherry-pick-7122-to-release-6.1 branch from d3d3bc7 to a179f10 Compare September 22, 2023 09:46
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.55%. Comparing base (f4d1cb7) to head (a179f10).
Report is 9 commits behind head on release-6.1.

Files with missing lines Patch % Lines
server/config/persist_options.go 0.00% 3 Missing ⚠️
server/server.go 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.1    #7125      +/-   ##
===============================================
+ Coverage        75.46%   75.55%   +0.08%     
===============================================
  Files              307      307              
  Lines            30589    30594       +5     
===============================================
+ Hits             23085    23116      +31     
+ Misses            5506     5483      -23     
+ Partials          1998     1995       -3     
Flag Coverage Δ
unittests 75.55% <45.45%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 26, 2024
@rleungx rleungx requested review from lhy1024 and HuSharp and removed request for nolouch September 10, 2024 07:22
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 10, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 10, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 10, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-10 07:25:10.777409551 +0000 UTC m=+341180.517833489: ☑️ agreed by lhy1024.
  • 2024-09-10 08:24:18.930328013 +0000 UTC m=+344728.670751952: ☑️ agreed by HuSharp.

@ti-chi-bot ti-chi-bot bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Sep 10, 2024
@ti-chi-bot ti-chi-bot bot merged commit 5c8d3f3 into tikv:release-6.1 Sep 10, 2024
18 checks passed
@HuSharp HuSharp deleted the cherry-pick-7122-to-release-6.1 branch September 10, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants