-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replication mode: fix wrong available store list #7222
Conversation
fix tikv#7221 Signed-off-by: disksing <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: disksing <[email protected]>
Signed-off-by: disksing <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
Signed-off-by: disksing <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #7222 +/- ##
==========================================
- Coverage 74.65% 74.45% -0.20%
==========================================
Files 442 442
Lines 47744 47897 +153
==========================================
+ Hits 35642 35661 +19
- Misses 8957 9086 +129
- Partials 3145 3150 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
/merge |
@disksing: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: ed860a2
|
In response to a cherrypick label: new pull request created to branch |
close #7221 Signed-off-by: disksing <[email protected]> Co-authored-by: disksing <[email protected]>
close tikv#7221 Signed-off-by: disksing <[email protected]> Co-authored-by: disksing <[email protected]>
In response to a cherrypick label: new pull request created to branch |
close #7221 Signed-off-by: disksing <[email protected]> Co-authored-by: disksing <[email protected]>
In response to a cherrypick label: new pull request created to branch |
close tikv#7221 Signed-off-by: ti-chi-bot <[email protected]>
close tikv#7221 Signed-off-by: disksing <[email protected]> Co-authored-by: disksing <[email protected]>
What problem does this PR solve?
Issue Number: Close #7221 #7218
What is changed and how does it work?
As now
canSync
andhasMajority
are calculated using placement rules, we can contain stores that have only learners in avalable stores list.This PR also fix a minor bug that relates to available stores id comparsion.
Check List
Tests
Related changes
Release note