Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replication mode: fix wrong available store list (#7222) #7224

Merged
merged 5 commits into from
Oct 18, 2023
Merged

replication mode: fix wrong available store list (#7222) #7224

merged 5 commits into from
Oct 18, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7222

What problem does this PR solve?

Issue Number: Close #7221 #7218

What is changed and how does it work?

As now canSync and hasMajority are calculated using placement rules, we can contain stores that have only learners in avalable stores list.

This PR also fix a minor bug that relates to available stores id comparsion.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

None.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Oct 18, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 18, 2023
Merged
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 18, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and rleungx October 18, 2023 07:10
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 18, 2023
@disksing
fix build
94e1981 
Signed-off-by: disksing <[email protected]>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 18, 2023
@disksing
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 18, 2023

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 18, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 94e1981

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
server/replication/replication_mode.go 82.74% <92.59%> (-0.07%) ⬇️

... and 24 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@lhy1024
Copy link
Contributor

lhy1024 commented Oct 18, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 18, 2023

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit e0ab17c into tikv:release-6.5 Oct 18, 2023
17 checks passed
disksing added a commit to oh-my-tidb/pd that referenced this pull request Oct 30, 2023
@ti-chi-bot @disksing
replication mode: fix wrong available store list (tikv#7222) (tikv#7224)
0f471b9 
close tikv#7221

Signed-off-by: disksing <[email protected]>

Co-authored-by: disksing <[email protected]>
disksing added a commit to oh-my-tidb/pd that referenced this pull request Feb 1, 2024
@ti-chi-bot @disksing
replication mode: fix wrong available store list (tikv#7222) (tikv#7224)
d8cee91 
close tikv#7221

Signed-off-by: disksing <[email protected]>

Co-authored-by: disksing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@disksing disksing disksing approved these changes

@HunDunDM HunDunDM Awaiting requested review from HunDunDM

@rleungx rleungx Awaiting requested review from rleungx

Assignees

@disksing disksing

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @disksing @lhy1024