-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schedule/coordinator.go:Fix errors in the comments since the DefaultP… #8174
Conversation
…atrolRegionInterval changed Signed-off-by: Shirly <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
pkg/schedule/coordinator.go
Outdated
@@ -52,7 +52,8 @@ const ( | |||
// pushOperatorTickInterval is the interval try to push the operator. | |||
pushOperatorTickInterval = 500 * time.Millisecond | |||
|
|||
patrolScanRegionLimit = 128 // It takes about 14 minutes to iterate 1 million regions. | |||
// It takes about 1.3 minutes to iterate 1 million regions(with DefaultPatrolRegionInterval=10ms). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an ideal situation, if the consumer side is smaller than the production side, then it will take longer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better to write 1000000/128*10/60/1000
here to indicate the calculation progress and emphasize it's an ideal situation?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8174 +/- ##
==========================================
- Coverage 77.42% 77.40% -0.02%
==========================================
Files 471 471
Lines 61367 61367
==========================================
- Hits 47511 47503 -8
- Misses 10292 10300 +8
Partials 3564 3564
Flags with carried forward coverage won't be shown. Click here to find out more. |
…atrolRegionInterval changed Signed-off-by: Shirly <[email protected]>
/check-issue-triage-complete |
/merge |
@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: ce44c37
|
@AndreMouche: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
…atrolRegionInterval changed
What problem does this PR solve?
Issue Number: Close #8173
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note