Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule/coordinator.go:Fix errors in the comments since the DefaultP… #8174

Merged
merged 3 commits into from
May 16, 2024

Conversation

AndreMouche
Copy link
Member

…atrolRegionInterval changed

What problem does this PR solve?

Issue Number: Close #8173

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented May 14, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels May 14, 2024
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx May 14, 2024 08:43
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 14, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 14, 2024
@@ -52,7 +52,8 @@ const (
// pushOperatorTickInterval is the interval try to push the operator.
pushOperatorTickInterval = 500 * time.Millisecond

patrolScanRegionLimit = 128 // It takes about 14 minutes to iterate 1 million regions.
// It takes about 1.3 minutes to iterate 1 million regions(with DefaultPatrolRegionInterval=10ms).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an ideal situation, if the consumer side is smaller than the production side, then it will take longer

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to write 1000000/128*10/60/1000 here to indicate the calculation progress and emphasize it's an ideal situation?

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.40%. Comparing base (91d4fad) to head (275e4bc).

❗ Current head 275e4bc differs from pull request most recent head 0f55227. Consider uploading reports for the commit 0f55227 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8174      +/-   ##
==========================================
- Coverage   77.42%   77.40%   -0.02%     
==========================================
  Files         471      471              
  Lines       61367    61367              
==========================================
- Hits        47511    47503       -8     
- Misses      10292    10300       +8     
  Partials     3564     3564              
Flag Coverage Δ
unittests 77.40% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 15, 2024
@HuSharp
Copy link
Member

HuSharp commented May 16, 2024

/check-issue-triage-complete

@HuSharp
Copy link
Member

HuSharp commented May 16, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented May 16, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 16, 2024

This pull request has been accepted and is ready to merge.

Commit hash: ce44c37

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 16, 2024
Copy link
Contributor

ti-chi-bot bot commented May 16, 2024

@AndreMouche: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit e105836 into tikv:master May 16, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schedule/coordinator: wrong comments for patrolRegions
4 participants