Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule/coordinator.go:Fix errors in the comments since the DefaultP… #8174

Merged
merged 3 commits into from
May 16, 2024
Merged

schedule/coordinator.go:Fix errors in the comments since the DefaultP… #8174

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
275e4bc
schedule/coordinator.go:Fix errors in the comments since the DefaultP…
AndreMouche May 14, 2024
ce44c37
schedule/coordinator.go:Fix errors in the comments since the DefaultP…
AndreMouche May 15, 2024
0f55227
Merge branch 'master' into patrolRegionComments
ti-chi-bot[bot] May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/schedule/coordinator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ const (
// pushOperatorTickInterval is the interval try to push the operator.
pushOperatorTickInterval = 500 * time.Millisecond

patrolScanRegionLimit = 128 // It takes about 14 minutes to iterate 1 million regions.
// It takes about 1.3 minutes to iterate 1 million regions(with DefaultPatrolRegionInterval=10ms).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an ideal situation, if the consumer side is smaller than the production side, then it will take longer

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to write 1000000/128*10/60/1000 here to indicate the calculation progress and emphasize it's an ideal situation?

patrolScanRegionLimit = 128
// PluginLoad means action for load plugin
PluginLoad = "PluginLoad"
// PluginUnload means action for unload plugin
Expand Down