Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

realclustertest: apply new style for some test cases #8732

Merged
merged 7 commits into from
Oct 22, 2024

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Oct 21, 2024

What problem does this PR solve?

Issue Number: Ref #8683

What is changed and how does it work?

Each case gets a separate HTTP client instead of a common client.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 21, 2024
@okJiang
Copy link
Member Author

okJiang commented Oct 21, 2024

/retest

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.98%. Comparing base (0402e15) to head (cd87697).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8732      +/-   ##
==========================================
- Coverage   70.10%   69.98%   -0.13%     
==========================================
  Files         517      517              
  Lines       79983    79983              
==========================================
- Hits        56076    55978      -98     
- Misses      20339    20439     +100     
+ Partials     3568     3566       -2     
Flag Coverage Δ
unittests 69.98% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: okJiang <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 22, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 22, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-22 04:07:49.53189848 +0000 UTC m=+324070.228689083: ☑️ agreed by JmPotato.
  • 2024-10-22 06:52:19.791345655 +0000 UTC m=+333940.488136264: ☑️ agreed by rleungx.

@okJiang
Copy link
Member Author

okJiang commented Oct 22, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit b155a7b into tikv:master Oct 22, 2024
24 of 25 checks passed
@okJiang okJiang deleted the real-cluster-test-2 branch October 22, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants