*: closed immediately if error rate is changed to 0 #8887
Conversation
ti-chi-bot
bot
added
release-note-none
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8887 +/- ##
==========================================
+ Coverage 76.25% 76.27% +0.01%
==========================================
Files 461 461
Lines 70399 70407 +8
==========================================
+ Hits 53685 53702 +17
+ Misses 13366 13355 -11
- Partials 3348 3350 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
rleungx
changed the title
|
Good idea. LGTM |
|
@Tema: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -19,13 +19,11 @@ import ( | |||
| "sync" | |||
| "time" | |||
|
|
|||
| "github.com/tikv/pd/client/errs" | |||
|
|
|||
| "github.com/pingcap/log" | |||
There was a problem hiding this comment.
why don't we enforce the order in CI?
There was a problem hiding this comment.
I add a linter for it, see #8925
| if s.cb.config.ErrorRateThresholdPct == 0 { | ||
| return cb.newState(now, StateClosed), nil | ||
| } |
There was a problem hiding this comment.
Would be great to and a simple test circuit_brealer_test.go to cover it
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/retest |
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nolouch, okJiang, Tema The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
What problem does this PR solve?
Issue Number: Ref #8678.
What is changed and how does it work?
This PR does the following changes:
Check List
Tests
Release note