Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: enable gci #8925

Merged
merged 2 commits into from
Dec 17, 2024
Merged

*: enable gci #8925

merged 2 commits into from
Dec 17, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Dec 17, 2024

What problem does this PR solve?

Issue Number: ref #4322

What is changed and how does it work?

see #8887 (comment)

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 17, 2024
@rleungx
Copy link
Member Author

rleungx commented Dec 17, 2024

/retest

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.24%. Comparing base (5d62787) to head (b16ee4c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8925      +/-   ##
==========================================
- Coverage   76.25%   76.24%   -0.01%     
==========================================
  Files         461      461              
  Lines       70395    70399       +4     
==========================================
- Hits        53677    53674       -3     
- Misses      13372    13379       +7     
  Partials     3346     3346              
Flag Coverage Δ
unittests 76.24% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 17, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 17, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-17 06:33:36.215296317 +0000 UTC m=+938606.304098853: ☑️ agreed by nolouch.
  • 2024-12-17 06:38:20.511104141 +0000 UTC m=+938890.599906684: ☑️ agreed by okJiang.

Copy link
Contributor

ti-chi-bot bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, niubell, nolouch, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 17, 2024
@ti-chi-bot ti-chi-bot bot merged commit e907aac into tikv:master Dec 17, 2024
25 checks passed
@rleungx rleungx deleted the enable-gci branch December 17, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants