WIP: Pg17

[Jo0]

No description provided.

[Jo0]

Had to nuke my local env, but I was trying to sort this out.

https://github.com/timescale/timescaledb-toolkit/actions/runs/11450107123/job/31888427034#step:6:190

[Jo0]

Had to nuke my local env, but I was trying to sort this out.

https://github.com/timescale/timescaledb-toolkit/actions/runs/11450107123/job/31888427034#step:6:190

So apparently this is in Rust 1.76?

rust-lang/rust#116866 (comment)

[Jo0]

Is there an argument against going to latest stable rust? pgrx looks to use latest stable based on their tools/rustup.sh

[Jo0]

Am I ultimately getting blocked by this missing GH_TOKEN failure? It's not building the new image with the target Rust 1.76 to be utilized in CI / Tests and Clippy and rustfmt?

https://github.com/timescale/timescaledb-toolkit/actions/runs/11464043831

Also how are you triggering manual re-runs @sebastianwebber? 😁

[Jo0]

Looking at past CI failures

   TimescaleDB only supports PostgreSQL 14, 15, 16 and 17

https://github.com/timescale/timescaledb-toolkit/actions/runs/11455829083/job/31872655924#step:5:37

https://github.com/timescale/timescaledb-toolkit/actions/runs/11435774212/job/31811826451#step:5:10

Run ./tools/install-timescaledb '12' '2.11.2' 'main'
fatal: repository '2.11.2' does not exist

I'm going to see about cleaning up the references to 12 and 13

[Jo0]

Recent commit fixes

- name: Build and install TimescaleDB
      if: ${{ (github.event_name == 'schedule' && github.event.schedule == '0 8 * * 1-4') || inputs.tsdb-commit != '' }}
      run: ./tools/install-timescaledb '${{ matrix.pgversion }}' '${{ inputs.tsdb-repo || 'https://github.com/timescale/timescaledb.git' }}' '${{ inputs.tsdb-commit == '' && 'main' || matrix.tsdb_commit || inputs.tsdb-commit }}'

from

run: ./tools/install-timescaledb '${{ matrix.pgversion }}' '${{ matrix.tsdb_commit || inputs.tsdb-repo || 'https://github.com/timescale/timescaledb.git' }}' '${{ inputs.tsdb-commit == '' && 'main' || matrix.tsdb_commit || inputs.tsdb-commit }}'

also

try to abide by the original sentiment of maintaining support for PG 13 in similar fashion to how we were continuing to test for PG 12

        include:
        # TimescaleDB as of 2.12.0 no longer supports PostgreSQL 12.
        # To allow us to do run CI against PostgreSQL 12, we therefore explicitly
        # remove all CI's, except if we are run against the latest supported TimescaleDB
        # version for PostgreSQL 12, which is 2.11.2
        - pgversion: 12
          container:
            image: debian-11-amd64
            os: debian
            version: "11" 
          tsdb_commit: 2.11.2
        # TimescaleDB as of 2.16.0 no longer supports PostgreSQL 13.
        # To allow us to do run CI against PostgreSQL 13, we therefore explicitly
        # remove all CI's, except if we are run against the latest supported TimescaleDB
        # version for PostgreSQL 13, which is 2.15.3
        - pgversion: 13
          container:
            image: debian-11-amd64
            os: debian
            version: "11" 
          tsdb_commit: 2.15.3

[Jo0]

I think at this point I'm poking at too much. I will wait for the next GH Action runs and set of feedback

[Jo0]

Am I ultimately getting blocked by this missing GH_TOKEN failure? It's not building the new image with the target Rust 1.76 to be utilized in CI / Tests and Clippy and rustfmt?

https://github.com/timescale/timescaledb-toolkit/actions/runs/11464043831

Been reviewing my changeset and looking through the workflows.

Getting the image built seems to be my blocker right now.

[philkra]

@Jo0 thank you for your contributions, the GitHub actions are failing as the PR comes from a fork. I'll merge this PR into a local branch and go from there.