Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update emoji-regex to v8.0.0 to support Unicode 12 #51

Merged
merged 2 commits into from
May 18, 2020

Conversation

kenime
Copy link
Contributor

@kenime kenime commented Apr 15, 2020

Intentionally not to update to latest version (v9.0.0) as Unicode 13 is not supported by Twemoji nor Emoji One.

Intentionally not to update to latest version (v9.0.0) as Unicode 13 is not supported by Twemoji nor Emoji One.
@tommoor
Copy link
Owner

tommoor commented Apr 16, 2020

Are you able to run yarn install to update the lock file in this PR too?

@tommoor tommoor requested a review from enzoferey May 5, 2020 15:25
@enzoferey
Copy link
Collaborator

enzoferey commented May 7, 2020

At least on my machine the snapshot for the test single letter aliases breaks (although no visual changes should be perceived by the user). Might be related to #52. In any case, I think we can safely merge this once you fix the snapshot @kenime 👍

Screenshot 2020-05-07 at 10 01 01

@favna
Copy link

favna commented May 12, 2020

If this is getting upgraded then it should go directly to emoji-regex v9.x, not v8.x.

Twemoji does support Unicode 13
This just means upgrading from the old MaxCDN URL to the v13 MaxCDN URL.
from

baseUrl: `//twemoji.maxcdn.com/2/${svg ? "svg/" : ""}`,

to //twemoji.maxcdn.com/v/latest/72x72/{CODEPOINT}.png, or https://twemoji.maxcdn.com/v/latest/svg/{CODEPOINT}.svg for SVGs


As for EmojiOne (now called JoyPixel)... well... for one they do not support Unicode 13. That aside however, there is a far bigger issue. I'm honestly inclined to suggest we should make this a major version upgrade for the package and remove JoyPixel support. Why? Well this library still relies on EmojiOne v2, however v2 has this in the README

JoyPixels version 2 is no longer supported or distributed

In v3 they went from a FOSS license to a Freemium license where businesses have to pay hefty prices ($99 - $1299!!) to use their library so if the intention of this library is to be fully FOSS then we cannot use, and strictly prohibit the use of their freemium icons (https://github.com/joypixels/emoji-assets/tree/master/png) for enterprise use

The other solution is to make it a minor release (feature) and serve the freemium JoyPixel icons, for example https://raw.githubusercontent.com/joypixels/emoji-assets/master/png/64/1f602.png for 😂 . This however means that we have Unicode 13 support in Twemoji but not in JoyPixel, and it also means that we should add a note to the README that this library cannot be used by businesses as it would be against JoyPixel's license, and that they should instead find a


Example of a unicode 13 emoji in Twemoji:

Example of a unicode 13 emoji in Twemoji, SVG format (collapsed because it's huge - click the details text to expand)

Example of a Unicode 12 emoji in JoyPixel:


Notes:

  • twemoji /v/latest can also be /v/13.0.0 if we want to version lock it

@kenime
Copy link
Contributor Author

kenime commented May 18, 2020

@enzoferey yarn install was executed and yarn.lock was updated.

@favna I agree with you and there should be a separate major release to upgrade to unicode v13 and drop JoyPixel from default list (due to FOSS issue). This PR will then focus on fixing unicode v12 support in current major release (hence keeping emoji-regex v8.x).

@favna
Copy link

favna commented May 18, 2020

Yeah that strategy sounds like a good one

@enzoferey enzoferey merged commit c49a499 into tommoor:master May 18, 2020
@enzoferey
Copy link
Collaborator

So, indeed as I wrote at #51 (comment) test was broken -> https://github.com/tommoor/react-emoji-render/actions/runs/108577667. Fixing in a follow up PR.

This was referenced May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants