-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update emoji-regex to v8.0.0 to support Unicode 12 #51
Conversation
Intentionally not to update to latest version (v9.0.0) as Unicode 13 is not supported by Twemoji nor Emoji One.
Are you able to run |
At least on my machine the snapshot for the test |
If this is getting upgraded then it should go directly to Twemoji does support Unicode 13 react-emoji-render/src/index.js Line 20 in c9a51b7
to //twemoji.maxcdn.com/v/latest/72x72/{CODEPOINT}.png , or https://twemoji.maxcdn.com/v/latest/svg/{CODEPOINT}.svg for SVGs
As for EmojiOne (now called JoyPixel)... well... for one they do not support Unicode 13. That aside however, there is a far bigger issue. I'm honestly inclined to suggest we should make this a major version upgrade for the package and remove JoyPixel support. Why? Well this library still relies on EmojiOne v2, however v2 has this in the README
In v3 they went from a FOSS license to a Freemium license where businesses have to pay hefty prices ($99 - $1299!!) to use their library so if the intention of this library is to be fully FOSS then we cannot use, and strictly prohibit the use of their freemium icons (https://github.com/joypixels/emoji-assets/tree/master/png) for enterprise use The other solution is to make it a minor release (feature) and serve the freemium JoyPixel icons, for example Example of a unicode 13 emoji in Twemoji: Example of a unicode 13 emoji in Twemoji, SVG format (collapsed because it's huge - click the Example of a Unicode 12 emoji in JoyPixel: Notes:
|
@enzoferey @favna I agree with you and there should be a separate major release to upgrade to unicode v13 and drop JoyPixel from default list (due to FOSS issue). This PR will then focus on fixing unicode v12 support in current major release (hence keeping emoji-regex v8.x). |
Yeah that strategy sounds like a good one |
So, indeed as I wrote at #51 (comment) test was broken -> https://github.com/tommoor/react-emoji-render/actions/runs/108577667. Fixing in a follow up PR. |
Intentionally not to update to latest version (v9.0.0) as Unicode 13 is not supported by Twemoji nor Emoji One.