lakectl to present error while writing to protected branch #8454
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e12badc.
ItamarYuran
added
the
exclude-changelog
|
🎊 PR Preview edd426d has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-8454.surge.sh 🕐 Build time: 0.012s
🤖 By surge-preview |
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
ItamarYuran
force-pushed
the
8333-bug-lakectl-local-doesnt-mention-the-reason-commit-fails-when-writing-to-a-protected-branch
branch
from
4f43a89 to
33ca670
Compare
|
@ItamarYuran please move the PR to ready for review. |
idanovo
requested changes
Jan 5, 2025
There was a problem hiding this comment.
There are a couple of issues with the current solution:
- 403 (forbidden) status code might be a result of another issue than writing to a protected branch.
- Your solution works specifically for uploading an object with presign mode without using multiparts.
What if I delete an object instead of uploading one? I'll still have the same issue. - I would like to have some tests here to validate we show the reason why we failed when trying to apply changes (write/delete) to a protected branch.
ItamarYuran
force-pushed
the
8333-bug-lakectl-local-doesnt-mention-the-reason-commit-fails-when-writing-to-a-protected-branch
branch
from
c3eeadb to
cce44f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8333