Cleanup after ETH contract flow #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibz
force-pushed
the
ibz/20241112-cleanup
branch
from
451cc55
to
0bd3796
Compare
|
|
|
In TS3 we don't use these crosses. |
|
Is the info about the size somewhere on TT? |
ibz
force-pushed
the
ibz/20241112-cleanup
branch
2 times, most recently
from
c726a95
to
c7343ee
Compare
What do you mean? |
|
edit: Is the info about the size of the data somewhere on TT? Regarding the crosses, we use different cancel button. |
Yes, it disappeared for a while, now it should be back.
Good catch! I'll look into that. |
ibz
force-pushed
the
ibz/20241112-cleanup
branch
2 times, most recently
from
a623611
to
3aef883
Compare
obrusvit
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
LGTM.
- tested
stake,approve,transfer,transferwith unknown token and unknown contract withmodel_randmercurymodel_rthe screen with "Warning, Unknown contract. Continue only if you know what you are doing" has only "Confirm" option and a user can cancel only on the next screen but that's probably not a part of this cleanup PR.
- notes from Hans seems to be fixed
- have one code-wise suggestion
- maybe @matejcik would like to take a look as well
- not sure if we merge with the marquee broken but I guess yes, I'd be happy to start rebasing my PRs on top of this
Yes, the goal of this was to fix the warning and the |
ibz
force-pushed
the
ibz/20241112-cleanup
branch
from
3aef883
to
fc54ad1
Compare
matejcik
reviewed
Nov 18, 2024
matejcik
approved these changes
Nov 19, 2024
Commit c300576 introduced the `default_cancel` parameter to `show_warning` and `confirm_blob` rather using the already existing `flow_warning_hi_prio` which was doing the same thing. This commit reverts all the nonsense. [no changelog]
request_anim_frame will register a timer for RequestPaint, which will then cause a crash. This commit fixes the crash, but makes the marquee component not work. [no changelog]
Commit c300576 introduced `confirm_blob_with_optional_pagination` which proved to be unpopular and impractical. This commit brings back the old behaviour of having the `ask_pagination` parameter on `confirm_blob`. It also reverts back to using the old way of paginating `confirm_blob` on model R, which the aforementioned commit ignored and re-implemented from scratch. [no changelog]
ibz
force-pushed
the
ibz/20241112-cleanup
branch
from
313f806
to
69d448f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some of the mess caused by #4270
warning_hi_prioinstead of having that functionality duplicated intoconfirm_blobconfirm_blob_with_optional_paginationis gone, and we are back to havingask_paginationas a parameter onconfirm_blobNB: This PR prevents the
Marqueeon model R from crashing, but it also makes it not scroll anymore.