Adding T8codeMesh support. #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this ready for a review or does it require something else first? |
added 3 commits
November 15, 2024 13:27
…rixi2Vtk.jl into feature-t8code-support
Ready for review! |
benegee
previously approved these changes
Dec 20, 2024
|
t8code reference files are still missing in the Trixi2Vtk_reference_files repo. However, for t8code, testcases analogous to the p4est testcases are run and the same file names (not folders) for the reference solutions are used. Therefore the previously downloaded p4est reference files are picked up during the t8code tests. In 2D this works, the t8code results compare equal to the p4est results. In 3D, this is no longer the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title says it all.