Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-132959 / 25.04 / Mark extent read-only if underlying zvol is R/O #15195

Merged
merged 7 commits into from
Dec 12, 2024
Merged

NAS-132959 / 25.04 / Mark extent read-only if underlying zvol is R/O #15195

merged 7 commits into from
Dec 12, 2024

Conversation

bmeagherix
Copy link
Contributor

If a SCST extent is based upon a zvol, then keep the extent ro setting in sync with the zvol readonly property.

  • Update extent ro prop if zvol readonly changes.
  • Update zvol readonly prop if extent is ro changed
  • Add unit test test__target_readonly_extent
  • CI test run is here.
  • Also did some manual testing with Windows client.

@bugclerk bugclerk changed the title NAS-132959 NAS-132959 / 25.04 / NAS-132959 Dec 12, 2024
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-132959

@bmeagherix bmeagherix changed the title NAS-132959 / 25.04 / NAS-132959 NAS-132959 / 25.04 / Mark extent read-only if underlying zvol is R/O Dec 12, 2024
@bmeagherix bmeagherix requested a review from a team December 12, 2024 18:46
themylogin
themylogin approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@themylogin themylogin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@bmeagherix bmeagherix merged commit bca13ac into master Dec 12, 2024
2 checks passed
@bmeagherix bmeagherix deleted the NAS-132959 branch December 12, 2024 19:45
@bugclerk bugclerk mentioned this pull request Dec 12, 2024
Merged
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@themylogin themylogin themylogin approved these changes

Assignees
No one assigned
Labels
backport-24.10.2 backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bmeagherix @bugclerk @themylogin @yocalebo