Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cve): CVE list fixes & enhancements #229

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

kahboom
Copy link
Contributor

@kahboom kahboom commented Nov 8, 2024

Relates to #171

Changes

  • Add back in missing properties
  • Add CVE list components

@trust-git-bot
Copy link

trust-git-bot commented Nov 8, 2024

🚀 Storybook Deployed Preview: https://trustify-ui-pr-229-preview.surge.sh

@kahboom
Copy link
Contributor Author

kahboom commented Nov 8, 2024

@carlosthe19916 question for Monday -- any idea why the mocked context isn't working for the list view? do I need to mock the entire table library? I'm trying to follow this guide but without much luck: https://storybook.js.org/docs/writing-stories/mocking-data-and-modules/mocking-providers

carlosthe19916

This comment was marked as resolved.

@kahboom kahboom force-pushed the cve-list-enhancements branch from e526dfb to e6e533e Compare November 11, 2024 14:10
@kahboom kahboom changed the title feat(cve): CVE list fixes fix(cve): CVE list fixes & enhancements Nov 11, 2024
@kahboom kahboom force-pushed the cve-list-enhancements branch from e6e533e to d49ec15 Compare November 11, 2024 14:47
@kahboom kahboom marked this pull request as ready for review November 11, 2024 14:48
fix: rm length

fix: add join in case of multiple values
@kahboom kahboom force-pushed the cve-list-enhancements branch from d49ec15 to 88f7e5b Compare November 11, 2024 15:21
@kahboom
Copy link
Contributor Author

kahboom commented Nov 11, 2024

Updated with sorting enabled:

Screenshot 2024-11-11 at 3 42 13 PM

@carlosthe19916
Copy link
Member

Sorry for the delayed review

@carlosthe19916 carlosthe19916 merged commit 5acfac8 into trustification:main Nov 13, 2024
8 checks passed
@kahboom kahboom deleted the cve-list-enhancements branch November 13, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants