Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JVM leak #4092

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Fix JVM leak #4092

merged 1 commit into from
Nov 4, 2024

Conversation

vcoolish
Copy link
Contributor

@vcoolish vcoolish commented Nov 1, 2024

Fixes #4021

Changes:

  • Created phantom reference registry with one thread which cleans up objects when needed.
  • Also added instrumentation testing support for kotlin target, for KMP testing purposes.

@vcoolish vcoolish self-assigned this Nov 1, 2024
satoshiotomakan
satoshiotomakan approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshiotomakan satoshiotomakan marked this pull request as ready for review November 4, 2024 08:44
@satoshiotomakan satoshiotomakan merged commit 8121243 into dev Nov 4, 2024
12 checks passed
@satoshiotomakan satoshiotomakan deleted the jvm-leak-dev branch November 4, 2024 08:45
@satoshiotomakan satoshiotomakan mentioned this pull request Nov 5, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satoshiotomakan satoshiotomakan satoshiotomakan approved these changes

@ar-g ar-g Awaiting requested review from ar-g ar-g is a code owner

@JaimeToca JaimeToca Awaiting requested review from JaimeToca JaimeToca is a code owner

@rkokhatskyi rkokhatskyi Awaiting requested review from rkokhatskyi rkokhatskyi is a code owner

@Milerius Milerius Awaiting requested review from Milerius Milerius is a code owner

Assignees

@vcoolish vcoolish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vcoolish @satoshiotomakan