-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deployment.yaml #2
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bridgecrew has found 17 infrastructure configuration errors in this PR ⬇️
@@ -43,3 +43,37 @@ spec: | |||
targetPort: 80 | |||
selector: | |||
app: health-check | |||
--- | |||
apiVersion: apps/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error Description: Do not expose the docker daemon socket to containers
Category: Kubernetes | Severity: MEDIUM
Resource: Deployment [my-deployment], lines: 47 - 79
@@ -43,3 +43,37 @@ spec: | |||
targetPort: 80 | |||
selector: | |||
app: health-check | |||
--- | |||
apiVersion: apps/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error Description: Apply security context to your pods and containers
Category: Kubernetes | Severity: INFO
Resource: Deployment [my-deployment], lines: 47 - 79
@@ -43,3 +43,37 @@ spec: | |||
targetPort: 80 | |||
selector: | |||
app: health-check | |||
--- | |||
apiVersion: apps/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error Description: Minimize the admission of root containers
Category: Kubernetes | Severity: MEDIUM
Resource: Deployment [my-deployment], lines: 47 - 79
@@ -43,3 +43,37 @@ spec: | |||
targetPort: 80 | |||
selector: | |||
app: health-check | |||
--- | |||
apiVersion: apps/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error Description: Containers should run as a high UID to avoid host conflict
Category: Kubernetes | Severity: LOW
Resource: Deployment [my-deployment], lines: 47 - 79
@@ -43,3 +43,37 @@ spec: | |||
targetPort: 80 | |||
selector: | |||
app: health-check | |||
--- | |||
apiVersion: apps/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error Description: Ensure that the seccomp profile is set to docker/default or runtime/default
Category: Kubernetes | Severity: INFO
Resource: Deployment [my-deployment], lines: 47 - 79
app: deploy | ||
spec: | ||
containers: | ||
- name: health-check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error Description: Memory requests should be set
Category: Kubernetes | Severity: INFO
Resource: Deployment [my-deployment], lines: 61 - 74
app: deploy | ||
spec: | ||
containers: | ||
- name: health-check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error Description: Minimize the admission of containers with capabilities assigned
Category: Kubernetes | Severity: INFO
Resource: Deployment [my-deployment], lines: 61 - 74
app: deploy | ||
spec: | ||
containers: | ||
- name: health-check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error Description: Container should not be privileged
Category: Kubernetes | Severity: HIGH
Resource: Deployment [my-deployment], lines: 61 - 74
app: deploy | ||
spec: | ||
containers: | ||
- name: health-check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error Description: Use read-only filesystem for containers where possible
Category: Kubernetes | Severity: LOW
Resource: Deployment [my-deployment], lines: 61 - 74
app: deploy | ||
spec: | ||
containers: | ||
- name: health-check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error Description: Readiness Probe Should be Configured
Category: Kubernetes | Severity: INFO
Resource: Deployment [my-deployment], lines: 61 - 74
No description provided.