Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment.yaml #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions scenarios/health-check/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,37 @@ spec:
targetPort: 80
selector:
app: health-check
---
apiVersion: apps/v1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Do not expose the docker daemon socket to containers
Category: Kubernetes | Severity: MEDIUM
Resource: Deployment [my-deployment], lines: 47 - 79

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Apply security context to your pods and containers
Category: Kubernetes | Severity: INFO
Resource: Deployment [my-deployment], lines: 47 - 79

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Minimize the admission of root containers
Category: Kubernetes | Severity: MEDIUM
Resource: Deployment [my-deployment], lines: 47 - 79

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Containers should run as a high UID to avoid host conflict
Category: Kubernetes | Severity: LOW
Resource: Deployment [my-deployment], lines: 47 - 79

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Ensure that the seccomp profile is set to docker/default or runtime/default
Category: Kubernetes | Severity: INFO
Resource: Deployment [my-deployment], lines: 47 - 79

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Ensure that Service Account Tokens are only mounted where necessary
Category: Kubernetes | Severity: INFO
Resource: Deployment [my-deployment], lines: 47 - 79

kind: Deployment
metadata:
name: my-deployment
spec:
selector:
matchLabels:
app: deploy
template:
metadata:
labels:
app: deploy
spec:
containers:
- name: health-check
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Containers should not run with allowPrivilegeEscalation
Category: Kubernetes | Severity: MEDIUM
Resource: Deployment [my-deployment], lines: 61 - 74

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: CPU requests should be set
Category: Kubernetes | Severity: INFO
Resource: Deployment [my-deployment], lines: 61 - 74

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Minimize the admission of containers with the NET_RAW capability
Category: Kubernetes | Severity: INFO
Resource: Deployment [my-deployment], lines: 61 - 74

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Image should use digest
Category: Kubernetes | Severity: INFO
Resource: Deployment [my-deployment], lines: 61 - 74

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Image Tag should be fixed - not latest or blank
Category: Kubernetes | Severity: INFO
Resource: Deployment [my-deployment], lines: 61 - 74

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Liveness Probe Should be Configured
Category: Kubernetes | Severity: INFO
Resource: Deployment [my-deployment], lines: 61 - 74

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Memory requests should be set
Category: Kubernetes | Severity: INFO
Resource: Deployment [my-deployment], lines: 61 - 74

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Minimize the admission of containers with capabilities assigned
Category: Kubernetes | Severity: INFO
Resource: Deployment [my-deployment], lines: 61 - 74

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Container should not be privileged
Category: Kubernetes | Severity: HIGH
Resource: Deployment [my-deployment], lines: 61 - 74

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Use read-only filesystem for containers where possible
Category: Kubernetes | Severity: LOW
Resource: Deployment [my-deployment], lines: 61 - 74

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Readiness Probe Should be Configured
Category: Kubernetes | Severity: INFO
Resource: Deployment [my-deployment], lines: 61 - 74

image: madhuakula/k8s-goat-health-check:latest
resources:
limits:
memory: "100Mi"
cpu: "30m"
ports:
- containerPort: 80
# Custom Stuff
securityContext:
privileged: true
volumeMounts:
- mountPath: /custom/docker/docker.sock
name: docker-sock-volume
volumes:
- name: docker-sock-volume
hostPath:
path: /var/run/docker.sock
type: File