Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: j1 and theta for FES type models #336

Merged
merged 2 commits into from
Sep 10, 2024

feat: use model class attributes for file format and corrections

d173d35
Select commit
Loading
Failed to load commit list.
Merged

fix: j1 and theta for FES type models #336

feat: use model class attributes for file format and corrections
d173d35
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 10, 2024 in 0s

72.53% (+0.88%) compared to bd3d702

View this Pull Request on Codecov

72.53% (+0.88%) compared to bd3d702

Details

Codecov Report

Attention: Patch coverage is 34.17722% with 52 lines in your changes missing coverage. Please review.

Project coverage is 72.53%. Comparing base (bd3d702) to head (d173d35).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pyTMD/arguments.py 19.35% 49 Missing and 1 partial ⚠️
pyTMD/io/model.py 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   71.65%   72.53%   +0.88%     
==========================================
  Files          39       39              
  Lines       11042    10268     -774     
  Branches     1522     1368     -154     
==========================================
- Hits         7912     7448     -464     
+ Misses       2632     2356     -276     
+ Partials      498      464      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.