Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix difficultycolor for units with a level of -1. #1430

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gizzmo
Copy link
Contributor

@gizzmo gizzmo commented Dec 7, 2024

Since the inception of the difficultycolor tag, (yes i checked the git history) it has suffered from the issue of showing the grey trivial color for bosses, as their UnitLevel will return -1.

This change better matches oUF's difficulty tag.

Screenshot:
Top "??" uses [difficulty][level],
while lower uses [difficultycolor][level]
2024 12 07 15 44 57 652


Seeing as this is how the tag has always displayed, and no one really noticed (myself included). I'd assume everyone is used to it being that color. Thoughts?

@Repooc
Copy link
Member

Repooc commented Dec 8, 2024

I personally don't agree to change the tag as it has been like this since it was made and assumed it was on purpose, I don't see the need to change it as a user can just use the ouf's version at that point. Others may agree with you, so not closing it without other input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants