Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed border-color variable from #dee2e6 to #888 #38489

Closed
wants to merge 1 commit into from

Conversation

raghav1030
Copy link

@raghav1030 raghav1030 commented Apr 21, 2023

Description

Made changes in the _variables.scss file where I changed the value of border-color from #dee2e6 to #888 that would resolve the issue #38480.

fixes #38480

Motivation & Context

The border of some elements , specially in input form like checkboxes had very low contrast that made them slightly invisible

This change solves the border color invisibility for the elements like checkboxes , form inputs , etc.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • N/A New feature (non-breaking change which adds functionality)
  • N/A Refactoring (non-breaking change)
  • N/A Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • N/A My change introduces changes to the documentation
  • N/A I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@raghav1030 raghav1030 requested a review from a team as a code owner April 21, 2023 11:43
@raghav1030
Copy link
Author

hey there! I made some changes in _variables.scss file. please review it and if there's something more that I can do in it , Please tell?
Open for your valuable feedback....

@mdo
Copy link
Member

mdo commented Apr 22, 2023

Sorry, but we won't be changing the border color to be that dark. Let's keep the PRs at bay for now and discuss any potential changes in the issue. I could see us darkening things a little, but this is too much.

@mdo mdo closed this Apr 22, 2023
@xi xi mentioned this pull request Apr 24, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insufficient contrast on borders
3 participants