Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS: Make use of --bs-link-decoration and --bs-link-hover-decoration #39098

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

CSS: Make use of --bs-link-decoration and --bs-link-hover-decoration #39098

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
321d73e
Use some of our unused CSS variables
louismaximepiton Aug 23, 2023
8e7ac27
fix(review)
louismaximepiton Sep 13, 2023
d166b24
Merge branch 'main' into main-lmp-use-decoration-css-vars
julien-deramond Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scss/_buttons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,14 +172,14 @@
--#{$prefix}btn-box-shadow: 0 0 0 #000; // Can't use `none` as keyword negates all values when used with multiple shadows
--#{$prefix}btn-focus-shadow-rgb: #{to-rgb(mix(color-contrast($link-color), $link-color, 15%))};

text-decoration: $link-decoration;
text-decoration: var(--#{$prefix}link-decoration);
@if $enable-gradients {
background-image: none;
}

&:hover,
&:focus-visible {
text-decoration: $link-hover-decoration;
text-decoration: var(--#{$prefix}link-hover-decoration);
}

&:focus-visible {
Expand Down
4 changes: 2 additions & 2 deletions scss/_reboot.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,11 +242,11 @@ sup { top: -.5em; }

a {
color: rgba(var(--#{$prefix}link-color-rgb), var(--#{$prefix}link-opacity, 1));
text-decoration: $link-decoration;
text-decoration: var(--#{$prefix}link-decoration);

&:hover {
--#{$prefix}link-color-rgb: var(--#{$prefix}link-hover-color-rgb);
text-decoration: $link-hover-decoration;
text-decoration: var(--#{$prefix}link-hover-decoration);
}
}

Expand Down
2 changes: 1 addition & 1 deletion scss/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ $link-color: $primary !default;
$link-decoration: underline !default;
$link-shade-percentage: 20% !default;
$link-hover-color: shift-color($link-color, $link-shade-percentage) !default;
$link-hover-decoration: null !default;
$link-hover-decoration: underline !default;
louismaximepiton marked this conversation as resolved.
Show resolved Hide resolved

$stretched-link-pseudo-element: after !default;
$stretched-link-z-index: 1 !default;
Expand Down