Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: Make use of --bs-link-decoration and --bs-link-hover-decoration #39098

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Aug 23, 2023

Description

Make use of --bs-link-decoration and --bs-link-hover-decoration in Bootstrap.

Motivation & Context

More flexible for Bootstrap users.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #36293.

scss/_variables.scss Outdated Show resolved Hide resolved
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after suggested change is added

@julien-deramond
Copy link
Member

Tagged it as v5.4.0 since it's a new feature non-related to color modes fixes.

@AgentSmith0
Copy link

Is it really a new feature? Since the variable was there before, but it was just not used anywhere, so I would say it's more a bug fix.

@julien-deramond
Copy link
Member

Fingers are often pointed at us because regarding how we sometimes handle the SemVer. TBH, it's a bit difficult to evaluate what should be in a major, minor, or dot release depending on how advanced is the usage (basic, Sass customization, custom properties advanced usage, etc.).
Regarding this PR I have mixed feelings regarding the fact it's rather a bug fix or a "new feature" (at least an enhancement).
Let it for now for a v5.4.0 waiting for @twbs/css-review thoughts.
Depending on these thoughts, I can prioritize it for the next v5.3.3 to release it sooner.

@jcoyne
Copy link

jcoyne commented Dec 8, 2023

Thank you @louismaximepiton. This is just what I was looking for!

@AgentSmith0
Copy link

Is there a new feature release planned soon?

@julien-deramond
Copy link
Member

Is there a new feature release planned soon?

It's not planned yet. Release v5.3.3 is soon to be released and we still need to define if there will be a v5.3.4 before the v5.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New css variable option for link underlines
5 participants