Fix MDC handling in Slf4jLogger #850
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks: - laziness of `msg` parameter - dispatch to log4j Logger messages - MDC setup
This was referenced Jun 14, 2024
morgen-peschke
commented
Jun 25, 2024
slf4j/src/test/scala/org/typelevel/log4cats/slf4j/internal/Slf4jLoggerInternalSuite.scala
Outdated
Show resolved
Hide resolved
MDC leaks into context when logging without context, because it doesn't go through the codepath that clears the MDC before logging
morgen-peschke
changed the title
This is used to make sure that the MDC manipulation all happens on the same thread.
|
Quick ping to help prevent this from disappearing into the ether 😉 |
|
@rossabaker I'm not able to add reviewers, can you add a couple of people? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the handling of the MDC in
Slf4jLoggerto resolve questions raised in #851Changes:
Checks:
msgparameter