Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MDC handling in Slf4jLogger #850

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Fix MDC handling in Slf4jLogger #850

wants to merge 14 commits into from

Commits on Jun 14, 2024

  1. Expand test coverage of Slf4jLogger 

    Checks:
- laziness of `msg` parameter
- dispatch to log4j Logger messages
- MDC setup
    @morgen-peschke
    morgen-peschke committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    30f79f3 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Work around the collections change between 2.12 and 2.13

    @morgen-peschke
    morgen-peschke committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a808c2c View commit details
    Browse the repository at this point in the history

  2. Add test explicitly demonstrating MDC behavior

    @morgen-peschke
    morgen-peschke committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    97ad066 View commit details
    Browse the repository at this point in the history

  3. Attempt to salvage the log if the MDC is busted

    @morgen-peschke
    morgen-peschke committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    2d5bc1c View commit details
    Browse the repository at this point in the history

  4. Only log the context, not the MDC contents

    @morgen-peschke
    morgen-peschke committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    31abf17 View commit details
    Browse the repository at this point in the history

  5. Improve the test name

    @morgen-peschke
    morgen-peschke committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    2085d5d View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Update tests to capture additional MDC failure mode 

    MDC leaks into context when logging without context, because it doesn't
go through the codepath that clears the MDC before logging
    @morgen-peschke
    morgen-peschke committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c7c0d33 View commit details
    Browse the repository at this point in the history

  2. Colocate the logging levels in Slf4jLoggerInternal

    @morgen-peschke
    morgen-peschke committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7569e64 View commit details
    Browse the repository at this point in the history

  3. More sensible Hail-Mary when MDCAdapter is borked

    @morgen-peschke
    morgen-peschke committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e68ce85 View commit details
    Browse the repository at this point in the history

  4. Always handle the MDC

    @morgen-peschke
    morgen-peschke committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3bcbdec View commit details
    Browse the repository at this point in the history

  5. Suppress unused warning

    @morgen-peschke
    morgen-peschke committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    412781e View commit details
    Browse the repository at this point in the history

  6. Attempt to balance warn message changes between Scala 2/3

    @morgen-peschke
    morgen-peschke committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    72113b1 View commit details
    Browse the repository at this point in the history

  7. Override IORuntime in test 

    This is used to make sure that the MDC manipulation all happens on the
same thread.
    @morgen-peschke
    morgen-peschke committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    dcb6500 View commit details
    Browse the repository at this point in the history

  8. Fix unused import

    @morgen-peschke
    morgen-peschke committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    61ee3e9 View commit details
    Browse the repository at this point in the history