Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/invalide cache correctly #514

Merged
merged 5 commits into from
Aug 22, 2023
Merged

Fix/invalide cache correctly #514

merged 5 commits into from
Aug 22, 2023

Conversation

Siolto
Copy link
Collaborator

@Siolto Siolto commented Aug 22, 2023

Check the length of the _controls array (cache) with Object.keys as we are not using .push to add entries to the array

vobu
vobu approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@vobu vobu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could have seen that earlier as well, grmpf

@vobu vobu merged commit b7c72ad into main Aug 22, 2023
19 checks passed
@vobu vobu deleted the fix/invalide-cache-correctly branch August 22, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vobu vobu vobu approved these changes

@dominikfeininger dominikfeininger Awaiting requested review from dominikfeininger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siolto @vobu