Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/invalide cache correctly #514

Merged
merged 5 commits into from
Aug 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
---
name: Bug report
about: "help us squat that \U0001FAB3!"
title: ''
labels: ''
assignees: ''

title: ""
labels: ""
assignees: ""
---

**Describe the bug**
Expand Down
4 changes: 2 additions & 2 deletions SUPPORT.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Commercial Support

The recommended way of obtaining commercial support for `wdi5` is via [GitHub Sponsors](https://docs.github.com/en/sponsors), providing process- and financial-flows without bureaucratic hassles.
These are the companies and individuals offering commercial support for `wdi5`:
The recommended way of obtaining commercial support for `wdi5` is via [GitHub Sponsors](https://docs.github.com/en/sponsors), providing process- and financial-flows without bureaucratic hassles.
These are the companies and individuals offering commercial support for `wdi5`:

- [j&s-soft](https://github.com/sponsors/js-soft)

Expand Down
4 changes: 3 additions & 1 deletion src/lib/wdi5-bridge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@
await clientSide_injectTools(browserInstance) // helpers for wdi5 browser scope
result = result && (await clientSide_injectUI5(config, waitForUI5Timeout, browserInstance))

if (browserInstance._controls.length > 0) {
// we are not using _controls as an array, we are using it as an object. That's why the length property
// is not updated right away: https://stackoverflow.com/a/4424026
if (Object.keys(browserInstance._controls).length > 0) {
Logger.info("invalidating control map!")
browserInstance._controls = []
}
Expand Down Expand Up @@ -445,7 +447,7 @@
// eslint-disable-next-line @typescript-eslint/no-empty-function
return new Proxy(function () {}, handler)
}
// @ts-ignore

Check warning on line 450 in src/lib/wdi5-bridge.ts

View workflow job for this annotation

GitHub Actions / Run linters

Do not use "@ts-ignore" because it alters compilation errors
return makeFluent(browserInstance._asControl(ui5ControlSelector))
}
}
Expand Down
Loading