Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-1593] Add ActiveRequestTrackingHandler #1709

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UNDERTOW-1593] Add ActiveRequestTrackingHandler #1709

wants to merge 1 commit into from

Conversation

fl4via
Copy link
Member

@fl4via fl4via commented Dec 4, 2024

@fl4via fl4via added the new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) label Dec 4, 2024
@fl4via fl4via mentioned this pull request Dec 4, 2024
Open
jasondlee
jasondlee reviewed Dec 4, 2024
View reviewed changes
core/src/test/java/io/undertow/server/handlers/ActiveRequestTrackerTest.java
@@ -48,10 +48,8 @@ public void testRequestTracking() throws InterruptedException {
t.start();

List<RequestStatistics> trackedRequests = handler.getTrackedRequests();
int attempts = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this PR is attempting to do. It adds a variable that doesn't seem to be read and edits a comment. Were some changes not added?

@baranowb baranowb self-requested a review December 5, 2024 08:02
baranowb
baranowb requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@baranowb baranowb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like git add failed in some way ?

@baranowb baranowb added waiting PR update Awaiting PR update(s) from contributor before merging under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasondlee jasondlee jasondlee left review comments

@baranowb baranowb baranowb requested changes

Assignees
No one assigned
Labels
new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review waiting PR update Awaiting PR update(s) from contributor before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fl4via @jasondlee @baranowb